Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capitalization of Unix in multiprocessing documentation #96913

Merged
merged 1 commit into from Oct 1, 2022

Conversation

hawkinsw
Copy link
Contributor

@hawkinsw hawkinsw commented Sep 18, 2022

Fix capitalization of Unix in multiprocessing documentation

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 18, 2022
Copy link
Contributor

@rahul-kumi rahul-kumi left a comment

I was able to verify this change that corrects the deviation from the convention of addressing Unix in the documentation.
The change lgtm.

@hawkinsw
Copy link
Contributor Author

hawkinsw commented Sep 18, 2022

I was able to verify this change that corrects the deviation from the convention of addressing Unix in the documentation. The change lgtm.

Thank you @rahul-kumi!!

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Sep 30, 2022

Thanks! Would you mind also changing these:

library/os.path.rst:Unlike a unix shell, Python does not do any *automatic* path expansions.
library/test.rst:   Bind a unix socket, raising :exc:`unittest.SkipTest` if

And probably also these:

library/email.compat32-message.rst:      required by the unix mbox format.  For more flexibility, instantiate a
library/email.compat32-message.rst:      required by the unix mbox format.  For more flexibility, instantiate a
library/email.generator.rst:   *mangle_from_* is intended for use when messages are stored in unix mbox
library/email.generator.rst:   *mangle_from_* is intended for use when messages are stored in unix mbox

@JelleZijlstra JelleZijlstra self-assigned this Sep 30, 2022
@hawkinsw hawkinsw requested a review from a team as a code owner Sep 30, 2022
Change 'unix' to 'Unix' throughout documentation.
@hawkinsw
Copy link
Contributor Author

hawkinsw commented Sep 30, 2022

Thanks! Would you mind also changing these:

library/os.path.rst:Unlike a unix shell, Python does not do any *automatic* path expansions.
library/test.rst:   Bind a unix socket, raising :exc:`unittest.SkipTest` if

And probably also these:

library/email.compat32-message.rst:      required by the unix mbox format.  For more flexibility, instantiate a
library/email.compat32-message.rst:      required by the unix mbox format.  For more flexibility, instantiate a
library/email.generator.rst:   *mangle_from_* is intended for use when messages are stored in unix mbox
library/email.generator.rst:   *mangle_from_* is intended for use when messages are stored in unix mbox

All updated! I have changed the title of the commit to better reflect that the change is a little wider than initially suggested. I also rebased against master to make it smoother! I hope that it helps! Thanks for the review!

Will

@JelleZijlstra JelleZijlstra merged commit bd7d0e8 into python:main Oct 1, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 1, 2022

Thanks @hawkinsw for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 1, 2022

GH-97711 is a backport of this pull request to the 3.11 branch.

@bedevere-bot
Copy link

bedevere-bot commented Oct 1, 2022

GH-97712 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 1, 2022
(cherry picked from commit bd7d0e8)

Co-authored-by: Will Hawkins <8715530+hawkinsw@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 1, 2022
(cherry picked from commit bd7d0e8)

Co-authored-by: Will Hawkins <8715530+hawkinsw@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Oct 1, 2022
(cherry picked from commit bd7d0e8)

Co-authored-by: Will Hawkins <8715530+hawkinsw@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Oct 1, 2022
(cherry picked from commit bd7d0e8)

Co-authored-by: Will Hawkins <8715530+hawkinsw@users.noreply.github.com>
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Oct 2, 2022
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
(cherry picked from commit bd7d0e8)

Co-authored-by: Will Hawkins <8715530+hawkinsw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants