Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99811: Use correct variable to search for asctime #99812

Merged
merged 1 commit into from Nov 28, 2022
Merged

gh-99811: Use correct variable to search for asctime #99812

merged 1 commit into from Nov 28, 2022

Conversation

cemysce
Copy link
Contributor

@cemysce cemysce commented Nov 27, 2022 •
edited by bedevere-bot

@cemysce cemysce requested a review from vsajip as a code owner Nov 27, 2022
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Nov 27, 2022 •
edited

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot mentioned this pull request Nov 27, 2022
Closed
@bedevere-bot
Copy link

bedevere-bot commented Nov 27, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot
Copy link

bedevere-bot commented Nov 27, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@cemysce cemysce requested a review from vsajip Nov 27, 2022
vsajip
vsajip approved these changes Nov 28, 2022
View changes
@vsajip vsajip merged commit 1d1bb95 into python:main Nov 28, 2022
17 of 22 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Nov 28, 2022

Thanks @cemysce for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Nov 28, 2022

Thanks @cemysce for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Nov 28, 2022

GH-99851 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 28, 2022
@cemysce @miss-islington
pythongh-99811: Use correct variable to search for time in format str…
a2a8946 
…ing (pythonGH-99812)

Use correct variable to search for asctime
(cherry picked from commit 1d1bb95)

Co-authored-by: cemysce <13400533+cemysce@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 28, 2022
@cemysce @miss-islington
pythongh-99811: Use correct variable to search for time in format str…
0cd04bf 
…ing (pythonGH-99812)

Use correct variable to search for asctime
(cherry picked from commit 1d1bb95)

Co-authored-by: cemysce <13400533+cemysce@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 28, 2022

GH-99852 is a backport of this pull request to the 3.10 branch.

@cemysce cemysce deleted the patch-1 branch Nov 28, 2022
vsajip pushed a commit that referenced this pull request Nov 28, 2022
@miss-islington
[3.11] gh-99811: Use correct variable to search for time in format st…
5bbf8ed 
…ring (GH-99812) (GH-99851)

(cherry picked from commit 1d1bb95)
Co-authored-by: cemysce <13400533+cemysce@users.noreply.github.com>
vsajip pushed a commit that referenced this pull request Nov 28, 2022
@miss-islington
[3.10] gh-99811: Use correct variable to search for time in format st…
1b43fa6 
…ring (GH-99812) (GH-99852)

(cherry picked from commit 1d1bb95)
Co-authored-by: cemysce <13400533+cemysce@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cemysce @bedevere-bot @miss-islington @vsajip