Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41784: make PyUnicode_AsUTF8AndSize part of the limited API #22252

Merged
merged 3 commits into from Oct 19, 2020
Merged

bpo-41784: make PyUnicode_AsUTF8AndSize part of the limited API #22252

merged 3 commits into from Oct 19, 2020

Conversation

alex
Copy link
Member

@alex alex commented Sep 15, 2020 •
edited by bedevere-bot

@alex alex requested a review from methane Sep 15, 2020
@alex alex requested a review from a team as a code owner Sep 15, 2020
serhiy-storchaka
serhiy-storchaka reviewed Sep 15, 2020
View changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

See also my comments on the tracker.

Include/unicodeobject.h Show resolved Hide resolved
Include/cpython/unicodeobject.h Outdated Show resolved Hide resolved
@alex
Copy link
Member Author

alex commented Sep 15, 2020

Ok, I think I got all the comments. Thanks!

serhiy-storchaka
serhiy-storchaka reviewed Sep 18, 2020
View changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Please add in the documentation something like:

.. versionchanged:: 3.10
   This function is a part of the :ref:`limited API <stable>`.

And add corresponding entry in What's New.

@alex
Copy link
Member Author

alex commented Sep 18, 2020

Done

@zooba
Copy link
Member

zooba commented Oct 19, 2020

I can't see any What's New entry (I'm looking for Docs/whatsnew/3.10.rst changes). Maybe you added the NEWS entry? I can't tell with all the force pushes (which are unnecessary and only break reviews - we'll squash merge at the end).

@alex
Copy link
Member Author

alex commented Oct 19, 2020

Yes, there's a news entry.

@zooba
Copy link
Member

zooba commented Oct 19, 2020

That's not the same as a What's New entry: https://docs.python.org/3/whatsnew/3.9.html#c-api-changes

@alex
Copy link
Member Author

alex commented Oct 19, 2020

I didn't realize both were needed. I'll add a whatsnew entry now.

@zooba
Copy link
Member

zooba commented Oct 19, 2020

Thanks! I fixed the merge conflict, and will merge once CI is done.

@alex
Copy link
Member Author

alex commented Oct 19, 2020

Thanks much!

@zooba zooba merged commit 3a8fdb2 into python:master Oct 19, 2020
3 checks passed
@alex alex deleted the expose-utf8 branch Oct 19, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@alex @adorilson
bpo-41784: make PyUnicode_AsUTF8AndSize part of the limited API (pyth…
8536b57 
…onGH-22252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

@methane methane

@serhiy-storchaka serhiy-storchaka

@python/windows-team windows-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@alex @zooba @vstinner @methane @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot