Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-26131: Deprecate usage of load_module() #23469

Merged
merged 12 commits into from Dec 4, 2020
Merged

bpo-26131: Deprecate usage of load_module() #23469

merged 12 commits into from Dec 4, 2020

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Nov 22, 2020 •
edited by miss-islington

Raise an ImportWarning when the import system falls back on load_module(). As for implementations of load_module(), raise a DeprecationWarning.

https://bugs.python.org/issue26131

Automerge-Triggered-By: GH:brettcannon

@brettcannon
Copy link
Member Author

brettcannon commented Nov 22, 2020

The key difference between this PR and #22905 is the addition of deprecating load_module() for zipimport and the changes to test_venv to make it all work while pip still has six without a fix for its lack of exec_module().

@brettcannon brettcannon added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Dec 4, 2020
@brettcannon brettcannon merged commit 2de5097 into python:master Dec 4, 2020
3 checks passed
@brettcannon brettcannon deleted the deprecate-load_module branch Dec 4, 2020
@frenzymadness frenzymadness mentioned this pull request Dec 11, 2020
Closed
This was referenced Dec 11, 2020
Closed
Closed
@blueyed blueyed mentioned this pull request Dec 19, 2020
Closed
@asottile asottile mentioned this pull request Jan 13, 2021
Closed
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@brettcannon @adorilson
bpo-26131: Deprecate usage of load_module() (pythonGH-23469)
827db09 
Raise an ImportWarning when the import system falls back on load_module(). As for implementations of load_module(), raise a DeprecationWarning.
@hugovk hugovk mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou

@ericsnowcurrently ericsnowcurrently

@ncoghlan ncoghlan

@vsajip vsajip

@warsaw warsaw

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brettcannon @the-knights-who-say-ni @bedevere-bot