Skip to content

Update content/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-google-cloud-platform.md to reflect most recent version#23935

Closed
brucearctor wants to merge 3 commits intogithub:mainfrom
brucearctor:gcpoidc

Conversation

@brucearctor
Copy link

Why:

Closes ISSUE

What's being changed (if available, include any code snippets, screenshots, or gifs):

Updating doc as noted in #23934

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Feb 14, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
src/**
lib/redirects/**
package*.json
scripts/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 14, 2023
@brucearctor brucearctor changed the title updatedoc Update content/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-google-cloud-platform.md to reflect most recent version Feb 14, 2023
@brucearctor
Copy link
Author

LOL -- the only file I am trying to change is in that list. That doc is out of date!

@brucearctor
Copy link
Author

Will leave it to a human to close this [ or perhaps stale bot ] and/or someone to choose to perform same actions/update. Cheers -

@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-google-cloud-platform.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5
fpt
ghec
ghes@ 3.8 3.7 3.6 3.5

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@brucearctor Thank you for opening a PR and linking it to your issue! ✨

The bot above is to give us a heads up when we are reviewing. Some files we cannot accept changes to, but for this one, we will review it and check with the team before we merge it. It just adds an extra layer of security over certain files 👍

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 16, 2023
@github-actions
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
src/**
lib/redirects/**
package*.json
scripts/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@github-actions
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
src/**
lib/redirects/**
package*.json
scripts/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

ghost

This comment was marked as spam.

@brucearctor
Copy link
Author

@Patricia1966Wa : is there something I can help you with?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
src/**
lib/redirects/**
package*.json
scripts/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@brucearctor
Copy link
Author

@cmwilson21 -- anything else needed? it seems prudent to keep security docs rather up-to-date?

@cmwilson21
Copy link
Contributor

@brucearctor - Thanks for checking in on this again. We've checked with the team and this sort of update will need to be made internally. I'm going to go ahead and close this PR and make note for the team to update 💛

Thank you for your interest in improving GitHub Docs! 💖

@cmwilson21 cmwilson21 closed this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update doc to current version of Action: 'google-github-actions/auth'

2 participants