Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWrong timezone on commit #630
Open
Labels
Comments
|
Even though I didn't reproduce this issue, it certainly something that wasn't tested properly enough and thus is prone to not work correctly. I would appreciate any help with this one, such as a test which reproduces the issue, maybe even alongside a fix :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This happens when committing via call to repo.index.commit(message). The timezone value is off by 20 minutes. When I issue 'git log', the following shows:
commit 8767403c5e175b5bf69b4ba1d23e8462c722867e Author: Amol Date: Sat May 20 18:50:10 2017 +0530 'Solved.' commit 88a0953df5dc4036633e9f5a295291084b144064 Author: Amol Date: Sat May 20 17:28:13 2017 +0550 Solved. commit 3a0daff1a2655469d412cfd4ab61b00b8da3f63d Author: Amol Date: Sat May 20 14:42:33 2017 +0530 Updated readme.From the bottom, here's how the commits were made:
As you can see, when committed through GitPython, value for timezone is off by 20 minutes. It is an issue with code related to the commit operation. To verify, I added files to the repo using repo.index.add and then committed via 'git commit' on the command line, the timezone was right in this case.
I checked timezone reported by:
Both show the correct timezone, +0530, i.e., India Standard Time.