Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-96296 fix threading.Event.isSet() docstring #96297

Merged
merged 1 commit into from Aug 27, 2022

Conversation

dgiger42
Copy link
Contributor

@dgiger42 dgiger42 commented Aug 26, 2022

This PR updates the docstring for the deprecated method threading.Event.isSet() so that the docstring is consistent with the warning message.

Issue: #96296

I'm guessing this change is small enough not to need a news entry.

@bedevere-bot
Copy link

bedevere-bot commented Aug 26, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@benjaminp benjaminp merged commit e534440 into python:main Aug 27, 2022
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Aug 27, 2022

Thanks @dgiger42 for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 27, 2022
fixes pythongh-96296
(cherry picked from commit e534440)

Co-authored-by: Daniel Giger <danielg3432@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Aug 27, 2022

GH-96331 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 27, 2022
fixes pythongh-96296
(cherry picked from commit e534440)

Co-authored-by: Daniel Giger <danielg3432@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Aug 27, 2022

GH-96332 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Aug 27, 2022
fixes gh-96296
(cherry picked from commit e534440)

Co-authored-by: Daniel Giger <danielg3432@gmail.com>
miss-islington added a commit that referenced this pull request Aug 27, 2022
fixes gh-96296
(cherry picked from commit e534440)

Co-authored-by: Daniel Giger <danielg3432@gmail.com>
@dgiger42 dgiger42 deleted the fix_docstring branch Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants