PEP 661: Standardize module name #2795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PEP says that the module name is "sentinels" (plural) but the example imports Sentinel from the "sentinel" (singular) module. Not absolutely sure which one is intended but recent standards (secrets, dataclasses) have used the plural. CLA for Python signed, in case that's needed.
hugovk
approved these changes
Sep 17, 2022
CAM-Gerlach
approved these changes
Sep 17, 2022
|
@taleinat , any feedback on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The PEP says that the module name is "sentinels" (plural) but the example imports Sentinel from the "sentinel" (singular) module. Not absolutely sure which one is intended but recent standards (secrets, dataclasses) have used the plural.
CLA for Python signed, in case that's needed.