Skip to content

Fix pybind stubs20230526 #15308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix pybind stubs20230526 #15308

wants to merge 3 commits into from

Conversation

cielavenir
Copy link

  1. pybind11's std::array docstring was generating List[int[2]], which was not correct. Use annotated for array pybind/pybind11#4679 corrected the docstring to Annotated[List[int], FixedSize(2)], which is correct syntax. But stubgen has to be updated.
  2. pybind11's bind map could not be parsed by stubgen correctly, which was corrected.

/cc @rwgk @felixvd

(Explain how this PR changes mypy.)

@cielavenir cielavenir mentioned this pull request May 26, 2023
Merged
@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cielavenir