Swift: "contentsOf" sources #14879
Open
Swift: "contentsOf" sources #14879
+87
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
reviewed
Nov 22, 2023
Comment on lines
+19
to
+23
| exists(InitializerCallExpr ce, Argument arg | | ||
| ce.getAnArgument() = arg and | ||
| arg.getLabel() = ["contentsOf", "contentsOfFile", "contentsOfPath", "contentsOfDirectory"] and | ||
| arg.getExpr().getType().getUnderlyingType().getName() = ["URL", "NSURL"] and | ||
| this.asExpr() = ce |
There was a problem hiding this comment.
Any reason not to have a common implementation for this snippet that we can use in InitializerContentsOfLocalSource?
There was a problem hiding this comment.
Good idea, that will improve maintainability...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple heuristic matching of "contentsOf" functions as flow sources in Swift code. In practice many of the sources found by this heuristic are already modelled -
Data(contentsOfFile:)is especially common. But we now catch some more obscure stuff as well, e.g.NSDictionary(contentsOf:),NSImage(contentsOf:),NSArray(contentsOfFile:)andAVAudioPlayer(contentsOf:)...