Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: add Spring models #14913

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jcogs33
Copy link
Contributor

@jcogs33 jcogs33 commented Nov 27, 2023

This PR adds a path-injection sink for org.springframework.core.io.Resource#createRelative(String) and a source for org.springframework.web.util.UrlPathHelper#getPathWithinApplication in order to cover CVE-2019-3799.

Additional UrlPathHelper sources are also added and their existing taint steps are removed. Let me know if anything looks wrong with these changes.

@github-actions github-actions bot added the Java label Nov 27, 2023
Copy link
Contributor

github-actions bot commented Nov 27, 2023

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    `Spring <https://spring.io/>`_,``org.springframework.*``,29,489,117,4,,28,14,,35
+    `Spring <https://spring.io/>`_,``org.springframework.*``,38,481,118,5,,28,14,,35
-    Totals,,299,18929,2423,315,16,122,33,1,401
+    Totals,,308,18921,2424,316,16,122,33,1,401
  • Changes to framework-coverage-java.csv:
- org.springframework.core.io,2,,,,,,,,,,,,,,,,,,,,,,,1,,,,,,,,,1,,,,,,,,,,,,,,,
+ org.springframework.core.io,3,,,,,,,,,,,,,,,,,,,,,,,2,,,,,,,,,1,,,,,,,,,,,,,,,
- org.springframework.web.util,,,165,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,140,25
+ org.springframework.web.util,,9,157,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,9,132,25

@jcogs33 jcogs33 changed the title Java: add Spring taint steps Java: add Spring models Nov 27, 2023
@jcogs33 jcogs33 force-pushed the jcogs33/unsafe-url-forward_path-inj-related_cve-2019-3799 branch from 51babbf to ba3548b Compare November 29, 2023 19:47
@jcogs33 jcogs33 marked this pull request as ready for review November 30, 2023 21:09
@jcogs33 jcogs33 requested a review from a team as a code owner November 30, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant