Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39435: Make the first argument of pickle.loads() positional-only. #19846

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 1, 2020

It was positional-only de facto: documentation and two implementations
used three different name.

https://bugs.python.org/issue39435

It was positional-only de facto: documentation and two implementations
used three different name.
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@serhiy-storchaka
Copy link
Member Author

Oh, @gvanrossum and @ilevkivskyi were added to the reviewers list because some experimental changes to typing.py were pushed initially by mistake. Sorry for disturbance.

@serhiy-storchaka serhiy-storchaka merged commit 531d1e5 into python:master May 2, 2020
@serhiy-storchaka serhiy-storchaka deleted the pickle-loads-posonly branch May 2, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants