WIP: run finalizers before shutdown #18189
Open
+135
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disable audit hook (crashes) - Run finalizers a bit later (so sys.is_finalizing() is set) - Don't clear call tp_clear - Don't move legacy finalizers to gc.garbage list
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Before the interpreter shuts down, run finalizers (weakref callbacks and
__del__methods) using the GC machinery. This could be a cleaner way to shutdown since it is less likely finalizer code will be running while the interpreter is in an invalid state (i.e. part-way shutting down).This is just a quick proof-of-concept. It seems to run but quite a few unit tests fail.