WIP: Cache for obmalloc arena_map_is_used() #25130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open for 30 days with no activity. |
|
Closing, not worth doing, IMHO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment to add a small cache for the result of the arena_map_is_used() function. This function is performance critical. It is possible that using a cache could be a faster approach. Also, it could allow us to expand the arena tree map to cover a larger address space (e.g. full 64-bits) or to shrink its memory usage.
This needs a lot more polish before it is ready and even then it would be questionable if it's worth the extra complexity. Based on some preliminary benchmarking, it seems about as fast as without the cache. With some further optimization, I suspect it could be faster.