Skip to content

gh-117975: Ensure flush level is checked when configuring a logging MemoryHandler.#117976

Merged
vsajip merged 1 commit into
python:mainfrom
vsajip:fix-117975
Apr 17, 2024
Merged

gh-117975: Ensure flush level is checked when configuring a logging MemoryHandler.#117976
vsajip merged 1 commit into
python:mainfrom
vsajip:fix-117975

Conversation

@vsajip
Copy link
Copy Markdown
Member

@vsajip vsajip commented Apr 17, 2024

@miss-islington-app
Copy link
Copy Markdown

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 17, 2024
…ging MemoryHandler. (pythonGH-117976)

(cherry picked from commit 6d0bb43)

Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Apr 17, 2024

GH-117986 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Apr 17, 2024
vsajip pushed a commit that referenced this pull request Apr 17, 2024
@5P5
Copy link
Copy Markdown

5P5 commented Sep 16, 2024

python3.11 still broken in logging.handlers.MemoryHandler.

self.flushLevel = flushLevel

  File "/usr/lib/python3.11/logging/__init__.py", line 978, in handle
    self.emit(record)

TypeError: '>=' not supported between instances of 'int' and 'str'

@vsajip
Copy link
Copy Markdown
Member Author

vsajip commented Sep 18, 2024

3.11 is in security-fix-only mode, so this change will not be backported to that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants