CLOUDSTACK-10341: Reduce systemvmtemplate size, install nftables

[rohityadavcloud]

Description

This reduces systemvmtemplate size by 600MB and installs nftables,
updates iptables.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Manually built using packer and tested locally by running smoketests.

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• All new and existing tests passed.

[resmo]

while improving, I wonder do we already have --no-recommends? This would also skip installing docs and optimize disk space usage. I would even suggest to add it to apt.conf

cat > /etc/apt/apt.conf.d/01norecommend << EOF
APT::Install-Recommends "0";
APT::Install-Suggests "0";
EOF

Any thoughts?

[resmo]

LGTM

[rohityadavcloud]

Thanks @resmo, we indeed install packages with the --no-install-recommends flag https://github.com/apache/cloudstack/blob/master/tools/appliance/systemvmtemplate/scripts/install_systemvm_packages.sh#L46

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1833

[wido]

LGTM

[resmo]

LGTM

[rohityadavcloud]

Manual tests have passed, let me kick a final run.
@blueorangutan test matrix

[blueorangutan]

@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-2424)
Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
Total time taken: 104750 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2506-t2424-vmware-65.zip
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_routers.py
Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	Failure	1994.29	test_routers_network_ops.py
test_04_restart_network_wo_cleanup	Failure	3.00	test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:teardown	Error	0.00	test_service_offerings.py

[blueorangutan]

Trillian test result (tid-2423)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 109583 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2506-t2423-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermitten failure detected: /marvin/tests/smoke/test_routers.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_usage.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 61 look OK, 6 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_restart_network_wo_cleanup	Failure	4.24	test_routers.py
test_04_extract_template	Failure	128.32	test_templates.py
ContextSuite context=TestISOUsage>:setup	Error	0.00	test_usage.py
test_06_download_detached_volume	Failure	137.94	test_volumes.py
test_04_rvpc_network_garbage_collector_nics	Failure	278.52	test_vpc_redundant.py
test_hostha_enable_ha_when_host_in_maintenance	Error	3.93	test_hostha_kvm.py

[rohityadavcloud]

Test LGTM, failures are due to environment issues or not related to this PR. Merging this based on results and two review LGTMs.

[blueorangutan]

Trillian test result (tid-2428)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
Total time taken: 92895 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2506-t2428-xenserver-65sp1.zip
Intermitten failure detected: /marvin/tests/smoke/test_network.py
Intermitten failure detected: /marvin/tests/smoke/test_routers.py
Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
Smoke tests completed. 65 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_restart_network_wo_cleanup	Failure	5.03	test_routers.py
test_09_reboot_router	Error	178.95	test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:teardown	Error	0.00	test_service_offerings.py