Use improved log2() implementation for log10() #4248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes a bug in the log2() implementation, where very large negative integer arguments would not raise an exception (and instead would turn into NaNs).
youknowone
previously requested changes
Oct 25, 2022
Member
youknowone
left a comment
There was a problem hiding this comment.
Great! I left a subtle change request about bigint.
Co-authored-by: Jeong YunWon <69878+youknowone@users.noreply.github.com>
DimitrisJim
approved these changes
Oct 25, 2022
Member
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a bug in the
log2()implementation, where very large negative integer arguments would not raise an exception (and instead would turn into NaNs).Follow-up to #4241. Part of #1671.