Fixes: 6216 | Support vector machines #6237
Conversation
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
| def __init__( | ||
| self, *, C: float = np.inf, kern: str = "linear", gamma: float = None |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: C
| raise ValueError(f"Unknown kernel: {kern}") | ||
|
|
||
| # kernels | ||
| def __linear(self, x: ndarray, y: ndarray) -> float: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: y
| def __linear(self, x: ndarray, y: ndarray) -> float: | ||
| return np.dot(x, y) | ||
|
|
||
| def __rbf(self, x: ndarray, y: ndarray) -> float: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: y
| def __rbf(self, x: ndarray, y: ndarray) -> float: | ||
| return np.exp(-(self.gamma * np.dot(x - y, x - y))) | ||
|
|
||
| def fit(self, xs: list[ndarray], y: ndarray) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: y
| (n,) = np.shape(y) | ||
|
|
||
| # l = v because flake8... | ||
| def to_minimize(v: ndarray) -> float: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: v
| b += y[i] - y[i] * l_star[i] * self.kern(xs[i], xs[j]) | ||
| self.b = b / n | ||
|
|
||
| def predict(self, x: ndarray) -> int: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
|
could you please help me resolve these naming issues correctly? For example C was picked to match sklearns syntax. For the kernels, I would like to NOT have overly descriptive names, since the arguments are just vectors (ndarray). |
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.