Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] Add use of require.css and require.js #1
Conversation
loop back server address and composer order. are changed.
This is more of brainstorm than a pull request. This makes use of Component Installer's generated
require.jsandrequire.css, reducing the micro-management of dependencies, and the amount of HTTP requests.require.css: Concatenated stylesheet of all Component CSS filesrequire.js: Built RequireJS configuration for loading scripts, along with their dependencies@simensen and I had troubles getting RequireJS to pick up the correct base URL in Sculpin. We can get around that by telling Sculpin to register it directly in the template:
Was trying to use
hljs.initHighlightingOnLoad();here, and it wasn't quite working because I believe at the time the require callback is made, the page is already loaded and the event has already been triggered. I could be wrong though, but it is working with the following:Was wondering where this could improve, and was looking for both of your thoughts. I'm trying to get a better understanding of where Component Installer could be better, and how it could satisfy more use cases.
Thanks a lot! Stack looks great❤️