Skip to content

Clarify docs on IntEnum comparability #29790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

the-moonwitch
Copy link

Update documention to specify that IntEnum values can be compared to standard Enum values,
but will always compare non-equal.

Specify that IntEnum values *can* be compared to standard Enum values,
but will always compare non-equal.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@slavfox

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 26, 2021
@asvetlov
Copy link
Contributor

I don't think that the correction makes sense.
In Python, different object types are always compared as non-equal and never throw an exception.
apple != dog, whatever actual classes for apple and dog are.

@the-moonwitch
Copy link
Author

That's true, but only for equality; "can't be compared" implies to me behavior similar to how < and related work, where it throws a TypeError if the two types don't support it between each other, and following it up with an example that doesn't raise an exception seems unexpected.

On the other hand, that is what happens when comparing IntEnum and Enum values with <, so perhaps you're right. Please reject this PR if the change seems wrong 👍

@asvetlov asvetlov closed this Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants