Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39216: Fix constant folding optimization for positional only arguments #17837

Merged
merged 1 commit into from Jan 5, 2020
Merged

bpo-39216: Fix constant folding optimization for positional only arguments #17837

merged 1 commit into from Jan 5, 2020

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Jan 5, 2020 •
edited by bedevere-bot

pablogsal
pablogsal approved these changes Jan 5, 2020
View changes
Copy link
Member

@pablogsal pablogsal left a comment

LGTM

@pablogsal pablogsal merged commit b121a4a into python:master Jan 5, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Jan 5, 2020

Thanks @asottile for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 5, 2020
@asottile @miss-islington
Fix constant folding optimization for positional only arguments (pyth…
ad1e7a6 
…onGH-17837)

(cherry picked from commit b121a4a)

Co-authored-by: Anthony Sottile <asottile@umich.edu>
@bedevere-bot
Copy link

bedevere-bot commented Jan 5, 2020

GH-17841 is a backport of this pull request to the 3.8 branch.

@pablogsal
Copy link
Member

pablogsal commented Jan 5, 2020

Thanks again, @asottile ! 🎉

@asottile asottile deleted the posonly_opt_39216 branch Jan 5, 2020
miss-islington added a commit that referenced this pull request Jan 5, 2020
@miss-islington @asottile
Fix constant folding optimization for positional only arguments (GH-1…
49c108c 
…7837)

(cherry picked from commit b121a4a)

Co-authored-by: Anthony Sottile <asottile@umich.edu>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@asottile @shihai1991
Fix constant folding optimization for positional only arguments (pyth…
c636afc 
…onGH-17837)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@asottile @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni