fix: dir(concurrent.futures) and tab completion broken #137214
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed that in 3.14rc1, tab completion is broken on
concurrent.futures. Tryingdir, I got:There's a typo in the
__dir__function; it is trying to concatenate a list and a tuple. I could do[*__all__ , '__author__', '__doc__']instead if that's preferred.I didn't make an issue, but I can if that's preferred. Needs backport to 3.14. Also didn't add a test, but a test that checks
diron all modules would be useful. Static typing would have caught this.Bug introduced in #136381.