Skip to content

bpo-40927: Fix test_binhex when run twice #20764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2020
Merged

bpo-40927: Fix test_binhex when run twice #20764

merged 1 commit into from
Jun 10, 2020

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jun 9, 2020 •
edited by bedevere-bot
Loading

test_binhex now uses import_fresh_module() to ensure that it raises
DeprecationWarning each time.

https://bugs.python.org/issue40927

@vstinner
bpo-40927: Fix test_binhex when run twice
6fe8f9d 
test_binhex now uses import_fresh_module() to ensure that it raises
DeprecationWarning each time.
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jun 9, 2020
@vstinner vstinner mentioned this pull request Jun 9, 2020
Closed
@vstinner
Copy link
Member Author

vstinner commented Jun 9, 2020

Another fix: PR #20758.

@vstinner vstinner merged commit 9c24e2e into python:master Jun 10, 2020
@vstinner vstinner deleted the test_binhex branch June 10, 2020 17:54
@miss-islington
Copy link
Contributor

miss-islington commented Jun 10, 2020

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jun 10, 2020

Sorry @vstinner, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 9c24e2e4c10705d95258558348417a28007dac66 3.9

@bedevere-bot
Copy link

bedevere-bot commented Jun 10, 2020

GH-20789 is a backport of this pull request to the 3.9 branch.

vstinner added a commit that referenced this pull request Jun 10, 2020
@vstinner
bpo-40927: Fix test_binhex when run twice (GH-20764) (GH-20789)
af69325 
test_binhex now uses import_fresh_module() to ensure that it raises
DeprecationWarning each time.

(cherry picked from commit 9c24e2e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vstinner vstinner

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni