C++: fix equality refinement in new range analysis #13226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MathiasVP
reviewed
May 19, 2023
| exists(SemExpr e, D::Delta d1, D::Delta d2 | | ||
| unequalFlowStepIntegralSsa(v, pos, e, d1, reason) and | ||
| boundedUpper(e, b, d1) and | ||
| boundedUpper(e, b, d2) and |
Contributor
There was a problem hiding this comment.
Would it be possible to add a range analysis library-test for this as well? That would also help make this commit independent of the other commits.
ef96fef to
681cc4c
Compare
MathiasVP
reviewed
May 22, 2023
cpp/ql/test/experimental/query-tests/Security/CWE/CWE-193/constant-size/test.cpp
Show resolved
Hide resolved
See my last comment about test annotation.
MathiasVP
previously approved these changes
May 23, 2023
Contributor
MathiasVP
left a comment
There was a problem hiding this comment.
LGTM once DCA is happy!
MathiasVP
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.