Skip to content

C#: Extract enum underlying type from IL #4761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tamasvajk merged 8 commits into from
Dec 9, 2020
Merged

C#: Extract enum underlying type from IL #4761

tamasvajk merged 8 commits into from
Dec 9, 2020

Conversation

@tamasvajk
Copy link
Contributor

@tamasvajk tamasvajk commented Dec 1, 2020 •
edited
Loading

Previously we were reporting int on CIL extracted enum underlying types. This PR changes this by extracting the correct underlying type from TypeDefinitionHandles. Additionally, System.Enum is removed from the Enum QL class.

This PR adds commits on top of #4758.

C# differences C# differences
C# stats

@tamasvajk
Copy link
Contributor Author

tamasvajk commented Dec 1, 2020 •
edited
Loading

not to self: missing DB upgrade folder and new stats. Fix second commit message.

@github-actions github-actions bot added the C# label Dec 1, 2020
@tamasvajk tamasvajk force-pushed the feature/cil-enum-underlying branch from 7635072 to de4295a Compare December 2, 2020 09:06
@tamasvajk tamasvajk marked this pull request as ready for review December 2, 2020 09:07
@tamasvajk tamasvajk requested a review from a team as a code owner December 2, 2020 09:07
@tamasvajk tamasvajk changed the title C#: Extract enum eunderlying type from IL C#: Extract enum underlying type from IL Dec 2, 2020
@tamasvajk tamasvajk marked this pull request as draft December 2, 2020 10:28
@tamasvajk tamasvajk force-pushed the feature/cil-enum-underlying branch from de4295a to 01b4976 Compare December 3, 2020 12:52
@tamasvajk tamasvajk marked this pull request as ready for review December 3, 2020 13:13
@tamasvajk tamasvajk force-pushed the feature/cil-enum-underlying branch from 01b4976 to ffd9b3b Compare December 3, 2020 13:15
@tamasvajk

This comment has been minimized.

Sign in to view
@tamasvajk tamasvajk mentioned this pull request Dec 7, 2020
Merged
@tamasvajk
Copy link
Contributor Author

tamasvajk commented Dec 7, 2020

Stats job

@tamasvajk
Copy link
Contributor Author

tamasvajk commented Dec 8, 2020

Stats job

New stats job

hvitved
hvitved requested changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise LGTM.

hvitved
hvitved previously approved these changes Dec 8, 2020
View reviewed changes
@hvitved
Copy link
Contributor

hvitved commented Dec 8, 2020

Let's run this past CSharp-Differences before merging.

@tamasvajk tamasvajk force-pushed the feature/cil-enum-underlying branch from 6cc5875 to 6dcfd57 Compare December 8, 2020 15:41
@tamasvajk tamasvajk force-pushed the feature/cil-enum-underlying branch from 6dcfd57 to 2257a8d Compare December 8, 2020 15:43
@tamasvajk
Copy link
Contributor Author

tamasvajk commented Dec 8, 2020

I've rebased this PR, and pushed two extra commits (DB upgrade folder and change notes)

@tamasvajk
Copy link
Contributor Author

tamasvajk commented Dec 9, 2020

There are no changes in the diff job.

@tamasvajk tamasvajk merged commit b649ccd into github:main Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hvitved hvitved hvitved approved these changes

Assignees

No one assigned

Labels

C# documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tamasvajk @hvitved