Create a dataflow instance specifically for the Serializability library #6216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is number 5 used for anything else at the moment? Otherwise we could consider just renaming it (and possibly renaming number 6 as that is also for a reserved use case IIRC). We have plenty of copies already, so might as well try to keep the number down. |
Contributor
Author
|
They do all have other users, though few in number. |
Contributor
|
LGTM, but needs resync. |
aschackmull
reviewed
Aug 3, 2021
java/ql/src/semmle/code/java/frameworks/google/GoogleHttpClientApi.qll
Outdated
Show resolved
Hide resolved
aschackmull
reviewed
Aug 3, 2021
java/ql/src/semmle/code/java/frameworks/jackson/JacksonSerializability.qll
Outdated
Show resolved
Hide resolved
Otherwise because this dataflow instance populates AdditionalTaintStep there is an ever-present danger that a user will stumble into creating a recursive configuration, or at least that by using DataFlow5::Configuration for any other purpose they will needlessly recalculate the Serializability dataflow results.
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
e6d9c33 to
afa8278
Compare
Contributor
Author
|
Accepted suggestions and rebased |
Contributor
|
CI still looks very red for some reason. |
Contributor
Author
|
Looks like there were concurrent changes to |
aschackmull
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise because this dataflow instance populates AdditionalTaintStep there is an ever-present danger that a user will stumble into creating a recursive configuration, or at least that by using DataFlow5::Configuration for any other purpose they will needlessly recalculate the Serializability dataflow results.