Python: model Django v1 route setup #4545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Again need to remove trailing $, since inline-expectation tests still don't handle $
Added it to the `testapp` so it's easy to run the server to SEE that it works. Added it to `routing_test` so it's obvious this is supported by our modeling when we _know_ it's running Django 2/3.
tausbn
requested changes
Oct 23, 2020
Contributor
tausbn
left a comment
There was a problem hiding this comment.
Two minor comments. Otherwise this looks good to me.
| exists(DataFlow::TypeTracker t2 | result = urls(t2).track(t2, t)) | ||
| } | ||
|
|
||
| // NOTE: had to rename due to shadowing rules in QL |
Contributor
There was a problem hiding this comment.
Because this would shadow django::urls? That's unfortunate.
python/ql/test/experimental/library-tests/frameworks/django-v1/response_test.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Taus <tausbn@github.com>
tausbn
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was pleasantly easy to do, compared to all the other modeling I have been doing.