Skip to content

Conversation

@manlix
Copy link

@manlix manlix commented Feb 9, 2021

Replace naïve with naive in pathlib module documentation.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@manlix

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@Fidget-Spinner
Copy link
Member

Hi, thanks for the PR! however, I think the current docs are correct: https://ell.stackexchange.com/questions/51042/why-does-the-i-in-na%C3%AFve-have-two-dots

@manlix
Copy link
Author

manlix commented Feb 11, 2021

Good point. However I think documentation in English should consists of English alphabet characters.

@serverwentdown
Copy link
Contributor

@manlix
Copy link
Author

manlix commented Feb 11, 2021

@serverwentdown Good point. I think used to ï in some cases (like official names) is OK but one style everywhere is prefer.
Offer to see entiry CPython.

Matching ï in entiry CPython:

manlix@lab:~/git/cpython$ git grep -Ii 'ï'
Doc/library/pathlib.rst:   (a naïve approach would make ``PurePosixPath('foo/../bar')`` equivalent
Doc/whatsnew/2.1.rst:  complain about its lack of speed, and because it's often been used as a naïve
Lib/lib2to3/tests/data/different_encoding.py:print u'ßàáâãäåæçèéêëìíîïðñòóôõöøùúûüýþÿÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝÞ'
Lib/shlex.py:            self.wordchars += ('ßàáâãäåæçèéêëìíîïðñòóôõöøùúûüýþÿ'
Lib/shlex.py:                               'ÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝÞ')
Lib/test/test_doctest2.txt:  Ð<U+0089>Ð<U+008A>Ð<U+0088>Ð<U+0081>Ð<U+0082>
Lib/test/test_email/test_email.py:""", """From: ����� �������� <xxx@xxx>
Lib/test/test_email/test_email.py:Subject:   ��� ���������� ����� ����� � ��������� �� ����
Lib/test/test_email/test_email.py:�� ����� � ���� ������ ��� ��������
Misc/ACKS:Loïc Lajeanne
Misc/NEWS.d/3.5.4rc1.rst:implementation. Patch by Michaël Sghaïer.
Misc/NEWS.d/3.6.2rc1.rst:implementation. Patch by Michaël Sghaïer.
Misc/NEWS.d/3.7.0a1.rst:implementation. Patch by Michaël Sghaïer.

Matching naïve in entiry CPython:

manlix@lab:~/git/cpython$ git grep -I 'naïve'
Doc/library/pathlib.rst:   (a naïve approach would make ``PurePosixPath('foo/../bar')`` equivalent
Doc/whatsnew/2.1.rst:  complain about its lack of speed, and because it's often been used as a naïve

Count of matching naïve2 times:

manlix@lab:~/git/cpython$ git grep -Iio '\<naïve\>' | wc -l
2

Versus count of matching naive (without ï) — 122 times:

manlix@lab:~/git/cpython$ git grep -Iio '\<naive\>' | wc -l
122

As you can see using naïve in module pathlib is out of one style for documentation in English.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 14, 2021
@willingc
Copy link
Contributor

Hi @manlix, Both versions are acceptable in English. I'm going to close this PR. We welcome contributions. Please try to prioritize open documentation issues in bugs.python.org over typo fixes. Thanks!

@willingc willingc closed this Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants