Skip to content

C#: Generate Flow Models script #8559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelnebel merged 3 commits into from
Apr 5, 2022
Merged

C#: Generate Flow Models script #8559

michaelnebel merged 3 commits into from
Apr 5, 2022

Conversation

@michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Mar 25, 2022 •
edited
Loading

In this PR

  • we introduce a script, similar to the one that already exists for java, for generate QL Code source file based on the output of the CaptureModel queries.
  • Make a small fix for printing missing empty (ext) CSV column.

@michaelnebel michaelnebel force-pushed the csharp/generateflowmodelsscript branch from 352d1cc to c395c16 Compare March 30, 2022 07:10
@michaelnebel michaelnebel marked this pull request as ready for review March 30, 2022 11:57
@michaelnebel michaelnebel requested review from a team as code owners March 30, 2022 11:57
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Mar 30, 2022
@michaelnebel michaelnebel force-pushed the csharp/generateflowmodelsscript branch from bed6108 to c36c514 Compare April 1, 2022 13:19
hvitved
hvitved previously approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me.

@michaelnebel michaelnebel force-pushed the csharp/generateflowmodelsscript branch from c36c514 to 8c3be65 Compare April 4, 2022 14:08
@michaelnebel
Copy link
Contributor Author

michaelnebel commented Apr 4, 2022

@hvitved: Had to rebase due to a merge conflict.

@michaelnebel michaelnebel requested a review from hvitved April 4, 2022 14:08
@michaelnebel michaelnebel merged commit 1f72f6c into github:main Apr 5, 2022
@michaelnebel michaelnebel deleted the csharp/generateflowmodelsscript branch April 5, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hvitved hvitved hvitved approved these changes

Assignees

No one assigned

Labels

C# Java no-change-note-required This PR does not need a change note Ruby

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelnebel @hvitved