Java: Add synthetic nodes for LocalVariableDeclExprs in the AST view
#4339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
reviewed
Sep 24, 2020
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
This looks mostly good to me. Only comment is that it seems like you're missing tests for instanceof expressions and enhanced for statements.
Also, please make sure to have someone on the java language team review this as well since I'm not really familiar with this code.
aschackmull
reviewed
Sep 25, 2020
Contributor
Adding such tests would indeed be good. |
Add tests for `EnhcancedForStmt`s and `InstanceOfExpr`s. Rename LocalVarDeclParent to SingleLocalVarDeclParent
aschackmull
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4286
Adds synthetic nodes that contain one or more
LocalVariableDeclExprs to hold them along with their correspondingTypeAccess. The type access is not made a child of theLocalVariableDeclExprs since one type access can be shared by multipleLocalVariableDeclExpr.LocalVariableDeclStmtis excluded from this as a synthetic node there would serve no purpose.The synthetic node added for the initialisers of a
ForStmtis slightly different as the initialisers are not necassarilyLocalVariableDecExprs; but can also beAssignments.