[Docs] Fix approximated importlib.import_module()#9945
Merged
Conversation
Contributor
|
Thanks @orlnub123 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-10085 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 24, 2018
The spec gets stored on modules with the __spec__ attribute, not spec. (cherry picked from commit 78401f7) Co-authored-by: orlnub123 <orlnub123@gmail.com>
|
GH-10086 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 24, 2018
The spec gets stored on modules with the __spec__ attribute, not spec. (cherry picked from commit 78401f7) Co-authored-by: orlnub123 <orlnub123@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Oct 24, 2018
The spec gets stored on modules with the __spec__ attribute, not spec. (cherry picked from commit 78401f7) Co-authored-by: orlnub123 <orlnub123@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Oct 24, 2018
The spec gets stored on modules with the __spec__ attribute, not spec. (cherry picked from commit 78401f7) Co-authored-by: orlnub123 <orlnub123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec gets stored on modules with the
__spec__attribute, notspec. An easy way to test the validity of this fix is runningimport_module('collections.abc'), which failed previously.