Skip to content

bpo-27032, bpo-37328: Document removing HTMLParser.unescape().#22288

Merged
serhiy-storchaka merged 1 commit intopython:masterfrom
serhiy-storchaka:remove-htmlparser-unescape
Sep 17, 2020
Merged

bpo-27032, bpo-37328: Document removing HTMLParser.unescape().#22288
serhiy-storchaka merged 1 commit intopython:masterfrom
serhiy-storchaka:remove-htmlparser-unescape

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 17, 2020 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka merged commit a33f2c2 into python:master Sep 17, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Sep 17, 2020

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@serhiy-storchaka serhiy-storchaka deleted the remove-htmlparser-unescape branch September 17, 2020 08:49
@miss-islington
Copy link
Contributor

miss-islington commented Sep 17, 2020

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a33f2c2bae759fc9d06e1c032fd2026135f2df45 3.9

@terryjreedy
Copy link
Member

terryjreedy commented Sep 17, 2020

I am looking to discover the conflict and how to best resolve it.

@miss-islington
Copy link
Contributor

miss-islington commented Sep 17, 2020

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 17, 2020

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a33f2c2bae759fc9d06e1c032fd2026135f2df45 3.9

terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Sep 18, 2020
@terryjreedy
bpo-27032, bpo-37328: Document removing HTMLParser.unescape(). (pytho…
b87cb15 
…nGH-22288)

(cherry picked from commit a33f2c2)
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Sep 18, 2020
@terryjreedy @serhiy-storchaka
[3.9] bpo-27032, bpo-37328: Document removing HTMLParser.unescape(). (p…
7f37d05 
…ythonGH-22288).

(cherry picked from commit a33f2c2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Sep 18, 2020

GH-22293 is a backport of this pull request to the 3.9 branch.

@terryjreedy
Copy link
Member

terryjreedy commented Sep 18, 2020

The problem was that there was only 1 space above the following 'Porting...' in master, at least when this diff was created, while there were already 2 in the 3.9 version of the same file.

terryjreedy added a commit that referenced this pull request Sep 18, 2020
@terryjreedy @serhiy-storchaka
[3.9] bpo-27032, bpo-37328: Document removing HTMLParser.unescape() (G…
4daeb9e 
…H-22288)

(cherry picked from commit a33f2c2)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Sep 18, 2020

Thank you Terry!

ambv pushed a commit to ambv/cpython that referenced this pull request Oct 4, 2020
@terryjreedy @serhiy-storchaka @ambv
[3.9] bpo-27032, bpo-37328: Document removing HTMLParser.unescape() (p…
8dd4302 
…ythonGH-22288)

(cherry picked from commit a33f2c2)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@serhiy-storchaka
bpo-27032, bpo-37328: Document removing HTMLParser.unescape(). (pytho…
fac2786 
…nGH-22288)
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
@serhiy-storchaka serhiy-storchaka mentioned this pull request Apr 10, 2022
Closed
@methane methane mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@serhiy-storchaka @miss-islington @terryjreedy @bedevere-bot @methane @the-knights-who-say-ni