Skip to content

Permutation#2872

Closed
Kentwwx wants to merge 5 commits intoTheAlgorithms:masterfrom
Kentwwx:master
Closed

Permutation#2872
Kentwwx wants to merge 5 commits intoTheAlgorithms:masterfrom
Kentwwx:master

Conversation

@Kentwwx
Copy link

@Kentwwx Kentwwx commented Dec 11, 2021

Describe your change:

Add Permutation, one of the classic questions in backtracking, to the backtracking directory.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.

Weixiang Wang and others added 2 commits December 10, 2021 19:15
@Kentwwx Kentwwx closed this Dec 11, 2021
@Kentwwx Kentwwx reopened this Dec 11, 2021
@Kentwwx Kentwwx closed this Dec 11, 2021
@Kentwwx Kentwwx reopened this Dec 11, 2021
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, could you add some tests as in https://github.com/TheAlgorithms/Java/pull/2869/files?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 11, 2022
@github-actions
Copy link

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

@github-actions github-actions bot closed this Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants