refactor(@angular-devkit/schematic): replace any with unknown

[santoshyadavdev]

No description provided.

[alan-agius4]

Suggested change

&& typeof act.hasOwnProperty('kind')

[alan-agius4]

In all fairness I am not a big fan of this casting here, as this is hiding potential errors.

[alan-agius4]

Something like seems to be more "correct", but wondering if we should just stop at hasOwnProperty since it's the object has those 3 props it's should be an action.

export function isAction(action: unknown): action is Action {
  if (
    action
    && typeof action === 'object'
    && action.hasOwnProperty('path')
    && action.hasOwnProperty('id')
    && action.hasOwnProperty('kind')
  ) {
    const { kind, id, path } = action as { id: unknown, path: unknown, kind: unknown };
    if (
      typeof kind === 'string'
      && ['c', 'o', 'r', 'd'].includes(kind)
      && typeof id === 'number'
      && typeof path === 'string'
    ) {
      return true;
    }
  }

  return false;
}

//cc @clydin what do you think?

[clydin]

based on the usage of the function, I think we should consider deprecating it and leaving it as-is for now. I put together a PR that removes the only use internally: #18637

[alan-agius4]

SGTM

[alan-agius4]

@santoshyadavdev, mind opening a separate PR to deprecate the this method?

[santoshyadavdev]

Ahh cool @alan-agius4 will do that today.

[santoshyadavdev]

@alan-agius4 please see #18727, should I close this one.

[alan-agius4]

Thanks, I’ll close it for you.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}