Python: Handle Python 3.8 Enum._convert#3640
Merged
semmle-qlci merged 3 commits intogithub:masterfrom Jun 10, 2020
Merged
Conversation
tausbn
requested changes
Jun 10, 2020
Contributor
tausbn
left a comment
There was a problem hiding this comment.
This looks good. I have a few small suggestions (and a comment) but apart from that it looks ready to merge. 👍
python/ql/test/library-tests/PointsTo/regressions/missing/metaclass/test.py
Show resolved
Hide resolved
Co-authored-by: Taus <tausbn@gmail.com>
tausbn
approved these changes
Jun 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's hard to show in a test, but the following test gave results for
MaybeandMaybe_notunder Python 3.8, saying that theyis exported by __all__ but is not defined.codeql/python/ql/test/3/query-tests/Variables/undefined/enum_convert.py
Lines 1 to 8 in 52ddd79
This PR fixes the problem, and adds a case of points-to regression that caused the query to not just work out of the box.