Skip to content

Update migrating-from-azure-pipelines-to-github-actions.md#8979

Closed
tedescomicchidev wants to merge 2 commits intogithub:mainfrom
tedescomicchidev:main
Closed

Update migrating-from-azure-pipelines-to-github-actions.md#8979
tedescomicchidev wants to merge 2 commits intogithub:mainfrom
tedescomicchidev:main

Conversation

@tedescomicchidev
Copy link

Mentioning the ability to concatenate the stages similar to Azure Pipelines when leveraging the workflow_run webhook event trigger.

Why:

Closes [issue link]

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Mentioning the ability to concatenate the stages similar to Azure Pipelines when leveraging the `workflow_run` webhook event trigger.
@welcome
Copy link

welcome bot commented Aug 12, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 12, 2021
@ramyaparimi
Copy link
Contributor

@tedescomicchidev
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 12, 2021
Zringgo77
Zringgo77 previously approved these changes Aug 14, 2021
Copy link

@Zringgo77 Zringgo77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give me win 2000000

Sondiez
Sondiez previously approved these changes Sep 2, 2021

- Azure Pipelines supports a legacy _classic editor_, which lets you define your CI configuration in a GUI editor instead of creating the pipeline definition in a YAML file. {% data variables.product.prodname_actions %} uses YAML files to define workflows and does not support a graphical editor.
- Azure Pipelines allows you to omit some structure in job definitions. For example, if you only have a single job, you don't need to define the job and only need to define its steps. {% data variables.product.prodname_actions %} requires explicit configuration, and YAML structure cannot be omitted.
- Azure Pipelines supports _stages_ defined in the YAML file, which can be used to create deployment workflows. {% data variables.product.prodname_actions %} requires you to separate stages into separate YAML workflow files.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eveything looks great well done ✅

Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Great addition! Thanks for sharing this! I will make one minor wording change, then get this merged down for you.

@skedwards88 skedwards88 dismissed stale reviews from Sondiez, ghost , and Zringgo77 via 9831267 September 23, 2021 18:00
@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Sep 23, 2021
@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Sep 23, 2021
@skedwards88
Copy link
Contributor

@tedescomicchidev It looks like I don't have permission to resolve the merge conflict. I think if you enable the checkbox to allow maintainer edits, then I will be able to resolve this. (https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork ) Alternatively, could you resolve the merge conflict?

@skedwards88 skedwards88 enabled auto-merge (squash) September 23, 2021 18:18
@ramyaparimi
Copy link
Contributor

@tedescomicchidev The PR has some unresolved conflicts which is blocking the merge 💛 Could you please try resolving the conflict by merging into your working branch from main? Once the conflicts are resolved, I will be able to merge this PR ✨

Thanks so much for your time in contributing to the GitHub docs 💖

@korgpa

This comment has been minimized.

@ramyaparimi ramyaparimi removed the ready to merge This pull request is ready to merge label Oct 6, 2021
@github-actions
Copy link
Contributor

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Oct 13, 2021
@github-actions github-actions bot closed this Oct 17, 2021
auto-merge was automatically disabled October 17, 2021 16:55

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team stale There is no recent activity on this issue or pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants