Skip to content

setting-exit-codes-for-actions.md C#3508

Merged
janiceilene merged 4 commits intogithub:mainfrom
Willi0728:patch-2
Mar 25, 2021
Merged

setting-exit-codes-for-actions.md C#3508
janiceilene merged 4 commits intogithub:mainfrom
Willi0728:patch-2

Conversation

@Willi0728
Copy link
Contributor

@Willi0728 Willi0728 commented Feb 6, 2021

Why:

Update definitions

Closes [issue link]

What's being changed:

A more clear definition

Check off the following:

@welcome
Copy link

welcome bot commented Feb 6, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

@Willi0728
Copy link
Contributor Author

Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

-------reply-------
I already put the template in the first comment I posted.

@janiceilene
Copy link
Contributor

@Willi0728 Can you fill out the Why and What's being changed questions in the template?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2021

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Mar 9, 2021
@github-actions github-actions bot closed this Mar 13, 2021
@janiceilene
Copy link
Contributor

Stalebot didn't know that an update was added to the OP, reopening this and triaging it for review.

@janiceilene janiceilene reopened this Mar 16, 2021
@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed stale There is no recent activity on this issue or pull request labels Mar 16, 2021
@skedwards88 skedwards88 self-assigned this Mar 23, 2021
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM! I'll get this merged down for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Mar 23, 2021
@janiceilene janiceilene merged commit b497050 into github:main Mar 25, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants