Skip to content

C#: Use invariant culture in the extractor#5810

Merged
tamasvajk merged 1 commit into
github:mainfrom
tamasvajk:feature/culture
May 4, 2021
Merged

C#: Use invariant culture in the extractor#5810
tamasvajk merged 1 commit into
github:mainfrom
tamasvajk:feature/culture

Conversation

@tamasvajk

Copy link
Copy Markdown
Contributor

No description provided.

@tamasvajk tamasvajk requested a review from a team as a code owner April 30, 2021 09:36
@github-actions github-actions Bot added the C# label Apr 30, 2021

@hvitved hvitved left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to move this into ExtractStandalone and Run in Extractor.cs? Then we could also put the logic into a shared method.

@tamasvajk

Copy link
Copy Markdown
Contributor Author

Would it be better to move this into ExtractStandalone and Run in Extractor.cs? Then we could also put the logic into a shared method.

I wanted to make this the very first thing that happens. We're parsing input arguments before the standalone extraction start, and the argument parsing could also have culture dependent logic.

@hvitved

hvitved commented May 3, 2021

Copy link
Copy Markdown
Contributor

I wanted to make this the very first thing that happens. We're parsing input arguments before the standalone extraction start, and the argument parsing could also have culture dependent logic.

Makes sense. Perhaps it would still be good to encapsulate (and document) the logic in a static method in Extractor.cs?

@tamasvajk tamasvajk merged commit 05c0450 into github:main May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants