gh-142867: Fix trace --count showing annotations as missing#143161
Open
heathdutton wants to merge 2 commits into
Open
gh-142867: Fix trace --count showing annotations as missing#143161heathdutton wants to merge 2 commits into
heathdutton wants to merge 2 commits into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
66ef492 to
27aecaf
Compare
8d472d2 to
23dac04
Compare
|
built this commit and reran original bug report, confirm that this fixes the problem... the code change looks plausible (without knowing the code at all) |
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With PEP 649 (deferred annotation evaluation),
__annotate__code objects are stored but not executed during normal program flow. The_find_lines()function was including lines from these code objects, causing them to incorrectly appear as not covered in trace output.This fix skips
__annotate__code objects when determining executable lines.