Include @xcorail (GHSL) in code reviews for experimental queries#5212
Merged
Conversation
yo-h
previously approved these changes
Feb 24, 2021
yo-h
approved these changes
Feb 25, 2021
yo-h
left a comment
Contributor
There was a problem hiding this comment.
Should a similar change be made for CODEOWNERS in the codeql-go repo?
Contributor
Author
@xcorail: could you please do that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever a query is promoted out of
experimental, the GitHub Security Lab would like to congratulate that contributor by mentioning them on Twitter and possibly sending out some swag.This change adds @xcorail to the
experimentalsections in theCODEOWNERSfile, so he'll automatically get a ping when a query is promoted out ofexperimental. It's probably not ideal that he'll also be pinged for any query that goes intoexperimental, but I'll file a separate issue in which we can discuss solutions to that.@p0, @calumgrant, @jbj, @yo-h: let me know if you prefer a different solution!