Skip to content

bpo-42599: Remove PyModule_GetWarningsModule() of pylifecycle.c#23691

Merged
vstinner merged 1 commit into
python:masterfrom
shihai1991:po_remove_PyModule_GetWarningsModule
Dec 8, 2020
Merged

bpo-42599: Remove PyModule_GetWarningsModule() of pylifecycle.c#23691
vstinner merged 1 commit into
python:masterfrom
shihai1991:po_remove_PyModule_GetWarningsModule

Conversation

@shihai1991

@shihai1991 shihai1991 commented Dec 8, 2020

Copy link
Copy Markdown
Member

Removed PyModule_GetWarningsModule of pylifecycle.c that was useless now due to
the _warnings module was converted to a builtin module in 2.6.

https://bugs.python.org/issue42599

the _warnings module was converted to a builtin module in 2.6.
@shihai1991 shihai1991 force-pushed the po_remove_PyModule_GetWarningsModule branch from 1b0c3c7 to b9c6d41 Compare December 8, 2020 12:05
@vstinner vstinner merged commit 0f91f58 into python:master Dec 8, 2020
@shihai1991

Copy link
Copy Markdown
Member Author

Thanks, victor.

@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 3.x has failed when building commit 0f91f58.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/559/builds/418) and take a look at the build logs.
  4. Check if the failure is related to this commit (0f91f58) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/559/builds/418

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

411 tests OK.

10 slowest tests:

  • test_concurrent_futures: 3 min 59 sec
  • test_gdb: 3 min 32 sec
  • test_tokenize: 3 min 6 sec
  • test_multiprocessing_spawn: 2 min 46 sec
  • test_unparse: 2 min 30 sec
  • test_capi: 2 min 16 sec
  • test_lib2to3: 2 min 15 sec
  • test_peg_generator: 1 min 53 sec
  • test_asyncio: 1 min 52 sec
  • test_multiprocessing_forkserver: 1 min 28 sec

1 test altered the execution environment:
test_asyncio

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 7 min 15 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/asyncio/sslproto.py", line 321, in __del__
    self.close()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/asyncio/sslproto.py", line 316, in close
    self._ssl_protocol._start_shutdown()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdown
    self._abort()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/asyncio/sslproto.py", line 731, in _abort
    self._transport.abort()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/asyncio/selector_events.py", line 680, in abort
    self._force_close(None)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/asyncio/selector_events.py", line 731, in _force_close
    self._loop.call_soon(self._call_connection_lost, exc)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/asyncio/base_events.py", line 745, in call_soon
    self._check_closed()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/asyncio/base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Removed PyModule_GetWarningsModule() which is useless due to 
the _warnings module was converted to a builtin module in 2.6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants