Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Some old code in Statistics module is calling node_load() and user_load() when it doesn't need to do so. I came across this because of an apparent bug in Workbench Moderation: #1780182: Revision tab shown in node form, if node/x/track is clicked
I'll post a patch shortly.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | stats-node-user-load-removal-1863260-7.patch | 921 bytes | nohup |
| #1 | stats-node-user-load-removal--no-whitespace-fix-1863260-1.patch | 2.21 KB | stevector |
| #1 | stats-node-user-load-removal-1863260-1.patch | 7.89 KB | stevector |
Comments
Comment #1
stevectorI'm posting two patches. The real patch is mostly whitespace fixes. The patch without the whitespace fix makes the change easier to see.
Comment #3
stevectorHmm, failing tests is one thing, but they shouldn't fail different tests.
Comment #4
stevector#1: stats-node-user-load-removal-1863260-1.patch queued for re-testing.
Comment #5
stevector#1: stats-node-user-load-removal--no-whitespace-fix-1863260-1.patch queued for re-testing.
Comment #6
iamEAP commentedNeither of these routes exist in 8.x anymore. Moving to 7.x
Comment #6.0
iamEAP commentedFixing link to other d.o issue
Comment #7
nohup commentedWith the 'me' alias module enabled user/me/track/navigation results in a "page not found". The 'me' modules replaces the user id in the URL with the string 'me'. The statistics module uses
user_load(arg(1))to load the user from the argument which fails because the user id in the URL was replaced with 'me'. The following patch usersmenu_get_objectto load the user.Comment #8
nohup commentedupdating status