This repository was archived by the owner on Dec 3, 2023. It is now read-only.
feat: add google-cloud-core-bom artifact#13
Merged
chingor13 merged 3 commits intogoogleapis:masterfrom Sep 6, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
============================================
- Coverage 66.46% 66.43% -0.04%
- Complexity 362 367 +5
============================================
Files 34 34
Lines 1858 1865 +7
Branches 234 236 +2
============================================
+ Hits 1235 1239 +4
- Misses 521 524 +3
Partials 102 102
Continue to review full report at Codecov.
|
elharo
approved these changes
Sep 6, 2019
| <parent> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-shared-config</artifactId> | ||
| <version>0.1.0</version> |
Contributor
There was a problem hiding this comment.
should this version be synced with the rest of the repo?
Contributor
Author
There was a problem hiding this comment.
Fixed the version of the bom. The parent project is an external parent that contains the shared build/testing/release configuration across the split repositories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to JLBP-15, all multi-module projects should produce a bom to keep versions in sync.
The google-cloud-bom can import this bom, rather than specifying the versions.