Skip to content

docs: document retry settings in sample #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olavloite merged 2 commits into from
May 26, 2021
Merged

docs: document retry settings in sample #1214

olavloite merged 2 commits into from
May 26, 2021

Conversation

@olavloite
Copy link
Collaborator

@olavloite olavloite commented May 26, 2021 •
edited
Loading

@olavloite olavloite requested a review from hengfengli May 26, 2021 08:44
@olavloite olavloite requested a review from a team as a code owner May 26, 2021 08:44
@olavloite olavloite requested a review from a team May 26, 2021 08:44
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 26, 2021
@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels May 26, 2021
@olavloite olavloite mentioned this pull request May 26, 2021
Merged
@olavloite olavloite requested a review from hengfengli May 26, 2021 11:06
hengfengli
hengfengli approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@olavloite
Copy link
Collaborator Author

olavloite commented May 26, 2021

The Windows build error is addressed by #1218

@olavloite olavloite merged commit ab4592d into master May 26, 2021
@olavloite olavloite deleted the document-retry-sample-settings branch May 26, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hengfengli hengfengli hengfengli approved these changes

Assignees

@eaball35 eaball35

Labels

api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

spanner: add comments to the timeout/retry code sample

3 participants

@olavloite @hengfengli @eaball35