Skip to content

Conversation

craiglabenz
Copy link
Contributor

Adds generated Bundles documentation pages for https://googleapis.dev/python/firestore

@craiglabenz craiglabenz added the type: docs Improvement to the documentation for an API. label Aug 9, 2021
@craiglabenz craiglabenz requested a review from a team August 9, 2021 13:37
@craiglabenz craiglabenz requested a review from a team as a code owner August 9, 2021 13:37
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2021
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Aug 9, 2021
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@craiglabenz One nit: we have traditionally preferred "imperative mode" for commit summary messages, e.g., docs: add generated docs for Bundles vs. docs: added generated docs for Bundles.

@craiglabenz craiglabenz merged commit 0176cc7 into master Aug 9, 2021
@craiglabenz craiglabenz deleted the bundle-docs branch August 9, 2021 17:26
@craiglabenz craiglabenz changed the title docs: added generated docs for Bundles docs: add generated docs for Bundles Aug 9, 2021
@craiglabenz
Copy link
Contributor Author

Sure probably should have renamed that before merging 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants