Fix new clippy lints#4337
Open
heaths wants to merge 1 commit intoAzure:mainfrom
Open
Conversation
Member
Author
|
New nightly, new clippy lint. 😔 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses newly introduced Clippy lints by removing unnecessary borrows in formatting/debug-print call sites, keeping the code behavior the same while satisfying updated lint rules.
Changes:
- Remove redundant
&borrows informat!arguments when building an Event Hubs partition source URL. - Remove redundant
&borrows inprintln!("{:?}", ...)debug output withinazure_coreerror response tests. - Remove redundant
&borrow in an error formatting path in the test-proxy bootstrap extraction logic.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/eventhubs/azure_messaging_eventhubs/src/consumer/mod.rs | Avoids needless borrows when formatting the partition source URL (Clippy cleanup). |
| sdk/core/azure_core/src/error/error_response.rs | Avoids needless borrows in debug prints inside tests (Clippy cleanup). |
| sdk/core/azure_core_test/src/proxy/bootstrap.rs | Avoids needless borrows in error formatting during proxy archive extraction (Clippy cleanup). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had a number of toolchain updates - especially nightly - that have blocked PRs from merging due to stylistic clippy lints, as well as some other lints that are worth considering.
We should be more thoughtful about when and how we update long-term, but for now we can at least reduce the noise.