Skip to content

Fix new clippy lints#4337

Open
heaths wants to merge 1 commit intoAzure:mainfrom
heaths:fix-clippy
Open

Fix new clippy lints#4337
heaths wants to merge 1 commit intoAzure:mainfrom
heaths:fix-clippy

Conversation

@heaths
Copy link
Copy Markdown
Member

@heaths heaths commented May 4, 2026

We've had a number of toolchain updates - especially nightly - that have blocked PRs from merging due to stylistic clippy lints, as well as some other lints that are worth considering.

We should be more thoughtful about when and how we update long-term, but for now we can at least reduce the noise.

Copilot AI review requested due to automatic review settings May 4, 2026 20:21
@heaths heaths requested review from RickWinter and j7nw4r as code owners May 4, 2026 20:21
@heaths heaths requested a review from LarryOsterman May 4, 2026 20:21
@heaths heaths requested a review from LarryOsterman as a code owner May 4, 2026 20:21
@heaths heaths requested a review from RickWinter May 4, 2026 20:21
@heaths
Copy link
Copy Markdown
Member Author

heaths commented May 4, 2026

New nightly, new clippy lint. 😔

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses newly introduced Clippy lints by removing unnecessary borrows in formatting/debug-print call sites, keeping the code behavior the same while satisfying updated lint rules.

Changes:

  • Remove redundant & borrows in format! arguments when building an Event Hubs partition source URL.
  • Remove redundant & borrows in println!("{:?}", ...) debug output within azure_core error response tests.
  • Remove redundant & borrow in an error formatting path in the test-proxy bootstrap extraction logic.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
sdk/eventhubs/azure_messaging_eventhubs/src/consumer/mod.rs Avoids needless borrows when formatting the partition source URL (Clippy cleanup).
sdk/core/azure_core/src/error/error_response.rs Avoids needless borrows in debug prints inside tests (Clippy cleanup).
sdk/core/azure_core_test/src/proxy/bootstrap.rs Avoids needless borrows in error formatting during proxy archive extraction (Clippy cleanup).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Core The azure_core crate Event Hubs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants