Update emitter to 0.40.0#4359
Open
heaths wants to merge 2 commits intoAzure:mainfrom
Open
Conversation
- Update `@azure-tools/typespec-azure-resource-manager` to 0.67.1 per upstream peerDependencies - Update `Update-Emitter.ps1` to also check peerDependencies from the remote package.json when syncing devDependencies in emitter-package.json, giving peer deps precedence over devDependencies - Restructure update logic so dependency sync runs independently of whether the emitter version itself changed Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the TypeSpec Rust emitter toolchain used by this repo (and its lockfiles) and refines the automation script that keeps eng/emitter-package.json in sync with upstream dependency constraints.
Changes:
- Bump
@azure-tools/typespec-rustto0.40.0and update@azure-tools/typespec-azure-resource-managerto0.67.1, regeneratingeng/emitter-package-lock.json. - Update
eng/scripts/Update-Emitter.ps1to sync dependency versions even when the emitter version doesn’t change, and to prefer upstreampeerDependenciesoverdevDependencieswhen updating ourdevDependencies. - Regenerate some Rust generated code in
azure_storage_blobas a result of the emitter update.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/storage/azure_storage_blob/src/generated/models/method_options.rs | Regenerated method option models; includes visibility changes on some structured-body fields. |
| eng/scripts/Update-Emitter.ps1 | Improves emitter update logic to also consider upstream peer deps and run dependency sync independently of emitter version changes. |
| eng/emitter-package.json | Bumps the emitter and aligns ARM TypeSpec package version. |
| eng/emitter-package-lock.json | Regenerated lockfile reflecting updated emitter and transitive/peer dependency graph. |
Files not reviewed (1)
- eng/emitter-package-lock.json: Language not supported
Default `$upstreamPeerDeps` and `$upstreamDevDeps` to empty objects when the upstream package.json omits those sections, preventing Set-StrictMode errors when accessing .PSObject.Properties on a null value. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
LarryOsterman
approved these changes
May 6, 2026
jhendrixMSFT
reviewed
May 7, 2026
| "devDependencies": { | ||
| "@azure-tools/typespec-azure-core": "0.67.0", | ||
| "@azure-tools/typespec-azure-resource-manager": "0.67.0", | ||
| "@azure-tools/typespec-azure-resource-manager": "0.67.1", |
Member
There was a problem hiding this comment.
This should be 0.67.4 which is the latest version.
jhendrixMSFT
reviewed
May 7, 2026
| "main": "dist/src/index.js", | ||
| "dependencies": { | ||
| "@azure-tools/typespec-rust": "0.39.1" | ||
| "@azure-tools/typespec-rust": "0.40.0" |
Member
There was a problem hiding this comment.
0.40.1 is now available (fixes the noise in method_options.rs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@azure-tools/typespec-azure-resource-managerto 0.67.1 perupstream peerDependencies
Update-Emitter.ps1to also check peerDependencies from theremote package.json when syncing devDependencies in emitter-package.json,
giving peer deps precedence over devDependencies
whether the emitter version itself changed
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com