fix: handle USB close errors during device enumeration#1
Open
BitHighlander wants to merge 1 commit into
Open
Conversation
client.close() in enumerate() sits outside the handle_errors context manager. When WebUSB releaseInterface() throws LIBUSB_ERROR_NOT_FOUND, it crashes the entire enumerate call including the hwi CLI. Wraps client.close() in try/except for both KeepKey and Trezor so enumeration completes gracefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client.close()in bothkeepkey.pyandtrezor.pyenumerate()functions sits outside thehandle_errorscontext managerreleaseInterface()throwsLIBUSB_ERROR_NOT_FOUND [-5], it crashes the entire enumerate call — including the officialhwi enumerateCLIclient.close()in try/except in both files so enumeration completes gracefullyTest plan
hwi enumeratecompletes successfully (was crashing before)hwi enumerate --expertworks