fix: error when passphrase provided but passphrase protection disabled#2
Open
BitHighlander wants to merge 2 commits into
Open
fix: error when passphrase provided but passphrase protection disabled#2BitHighlander wants to merge 2 commits into
BitHighlander wants to merge 2 commits into
Conversation
…bled Previously, if a BIP39 passphrase was provided but passphrase_protection was not enabled on the device, HWI silently ignored the passphrase and returned the default (no-passphrase) wallet. This could cause wallet apps like Sparrow and Specter to derive the wrong addresses without any indication of the problem. Now raises BadArgumentError in _check_unlocked() and adds warnings in enumerate() output for both KeepKey and Trezor devices.
Previously, if a BIP39 passphrase was provided but passphrase_protection was not enabled on the device, HWI silently ignored the passphrase and returned the default (no-passphrase) wallet. This could cause wallet apps like Sparrow and Specter to derive the wrong addresses without any indication of the problem. Now prints a warning to stderr in _check_unlocked() and adds warnings in enumerate() output for both KeepKey and Trezor devices. Non-breaking: existing integrations continue to work, they just see the warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
passphrase_protectionis disabled on the device, HWI silently ignores the passphrase and returns the default (no-passphrase) walletBadArgumentErrorin_check_unlocked()with a clear message to enable passphrase protection viatogglepassphraseenumerate()output for both KeepKey and Trezor devicesVerified
xpub6D6UctxqkwVv1s...xpub6DArWrRe4wygCG...(different wallet, confirmed working)Test plan
enumerate()without passphrase works normallyenumerate(password='test')with protection off returns warninggetmasterxpubwith passphrase but protection off raisesBadArgumentError