Avoid computing merge base for PR info in DDCI legacy mode#10624
Open
daniel-mohedano wants to merge 2 commits intomasterfrom
Open
Avoid computing merge base for PR info in DDCI legacy mode#10624daniel-mohedano wants to merge 2 commits intomasterfrom
daniel-mohedano wants to merge 2 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~fde088bb01, baseline=1.60.0-SNAPSHOT~2fa3c0c243
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1074863
Total [baseline] (8.774 s) : 0, 8773889
Agent [candidate] (1.066 s) : 0, 1065682
Total [candidate] (8.714 s) : 0, 8713770
section iast
Agent [baseline] (1.234 s) : 0, 1234250
Total [baseline] (9.402 s) : 0, 9402103
Agent [candidate] (1.231 s) : 0, 1230579
Total [candidate] (9.383 s) : 0, 9383083
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~fde088bb01, baseline=1.60.0-SNAPSHOT~2fa3c0c243
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (633.451 ms) : 0, 633451
BytebuddyAgent [candidate] (627.61 ms) : 0, 627610
AgentMeter [baseline] (29.271 ms) : 0, 29271
AgentMeter [candidate] (28.991 ms) : 0, 28991
GlobalTracer [baseline] (259.358 ms) : 0, 259358
GlobalTracer [candidate] (257.548 ms) : 0, 257548
AppSec [baseline] (33.429 ms) : 0, 33429
AppSec [candidate] (33.076 ms) : 0, 33076
Debugger [baseline] (62.668 ms) : 0, 62668
Debugger [candidate] (63.824 ms) : 0, 63824
Remote Config [baseline] (625.573 µs) : 0, 626
Remote Config [candidate] (615.664 µs) : 0, 616
Telemetry [baseline] (11.606 ms) : 0, 11606
Telemetry [candidate] (10.665 ms) : 0, 10665
Flare Poller [baseline] (6.852 ms) : 0, 6852
Flare Poller [candidate] (6.107 ms) : 0, 6107
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (796.527 ms) : 0, 796527
BytebuddyAgent [candidate] (795.429 ms) : 0, 795429
AgentMeter [baseline] (11.4 ms) : 0, 11400
AgentMeter [candidate] (11.317 ms) : 0, 11317
GlobalTracer [baseline] (249.199 ms) : 0, 249199
GlobalTracer [candidate] (248.254 ms) : 0, 248254
AppSec [baseline] (32.609 ms) : 0, 32609
AppSec [candidate] (30.652 ms) : 0, 30652
Debugger [baseline] (67.511 ms) : 0, 67511
Debugger [candidate] (68.066 ms) : 0, 68066
Remote Config [baseline] (537.729 µs) : 0, 538
Remote Config [candidate] (544.46 µs) : 0, 544
Telemetry [baseline] (8.687 ms) : 0, 8687
Telemetry [candidate] (8.573 ms) : 0, 8573
Flare Poller [baseline] (3.438 ms) : 0, 3438
Flare Poller [candidate] (3.451 ms) : 0, 3451
IAST [baseline] (27.138 ms) : 0, 27138
IAST [candidate] (27.11 ms) : 0, 27110
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~fde088bb01, baseline=1.60.0-SNAPSHOT~2fa3c0c243
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1070862
Total [baseline] (10.926 s) : 0, 10926279
Agent [candidate] (1.072 s) : 0, 1072119
Total [candidate] (10.866 s) : 0, 10866367
section appsec
Agent [baseline] (1.254 s) : 0, 1254019
Total [baseline] (11.187 s) : 0, 11187423
Agent [candidate] (1.241 s) : 0, 1241455
Total [candidate] (10.953 s) : 0, 10953073
section iast
Agent [baseline] (1.232 s) : 0, 1232115
Total [baseline] (11.143 s) : 0, 11143440
Agent [candidate] (1.24 s) : 0, 1240187
Total [candidate] (11.306 s) : 0, 11305668
section profiling
Agent [baseline] (1.19 s) : 0, 1189537
Total [baseline] (10.921 s) : 0, 10921167
Agent [candidate] (1.191 s) : 0, 1190995
Total [candidate] (10.886 s) : 0, 10885568
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~fde088bb01, baseline=1.60.0-SNAPSHOT~2fa3c0c243
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (630.536 ms) : 0, 630536
BytebuddyAgent [candidate] (631.734 ms) : 0, 631734
AgentMeter [baseline] (29.184 ms) : 0, 29184
AgentMeter [candidate] (29.308 ms) : 0, 29308
GlobalTracer [baseline] (258.711 ms) : 0, 258711
GlobalTracer [candidate] (258.879 ms) : 0, 258879
AppSec [baseline] (33.348 ms) : 0, 33348
AppSec [candidate] (33.406 ms) : 0, 33406
Debugger [baseline] (65.7 ms) : 0, 65700
Debugger [candidate] (65.673 ms) : 0, 65673
Remote Config [baseline] (643.524 µs) : 0, 644
Remote Config [candidate] (617.464 µs) : 0, 617
Telemetry [baseline] (10.074 ms) : 0, 10074
Telemetry [candidate] (10.618 ms) : 0, 10618
Flare Poller [baseline] (5.387 ms) : 0, 5387
Flare Poller [candidate] (4.562 ms) : 0, 4562
section appsec
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (668.576 ms) : 0, 668576
BytebuddyAgent [candidate] (660.295 ms) : 0, 660295
AgentMeter [baseline] (12.092 ms) : 0, 12092
AgentMeter [candidate] (11.943 ms) : 0, 11943
GlobalTracer [baseline] (260.317 ms) : 0, 260317
GlobalTracer [candidate] (257.983 ms) : 0, 257983
AppSec [baseline] (168.568 ms) : 0, 168568
AppSec [candidate] (167.899 ms) : 0, 167899
Debugger [baseline] (67.135 ms) : 0, 67135
Debugger [candidate] (66.916 ms) : 0, 66916
Remote Config [baseline] (648.878 µs) : 0, 649
Remote Config [candidate] (642.541 µs) : 0, 643
Telemetry [baseline] (9.719 ms) : 0, 9719
Telemetry [candidate] (9.497 ms) : 0, 9497
Flare Poller [baseline] (3.774 ms) : 0, 3774
Flare Poller [candidate] (3.713 ms) : 0, 3713
IAST [baseline] (25.689 ms) : 0, 25689
IAST [candidate] (25.325 ms) : 0, 25325
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (796.126 ms) : 0, 796126
BytebuddyAgent [candidate] (801.947 ms) : 0, 801947
AgentMeter [baseline] (11.285 ms) : 0, 11285
AgentMeter [candidate] (11.596 ms) : 0, 11596
GlobalTracer [baseline] (248.1 ms) : 0, 248100
GlobalTracer [candidate] (249.227 ms) : 0, 249227
AppSec [baseline] (31.362 ms) : 0, 31362
AppSec [candidate] (34.926 ms) : 0, 34926
Debugger [baseline] (68.744 ms) : 0, 68744
Debugger [candidate] (65.573 ms) : 0, 65573
Remote Config [baseline] (531.749 µs) : 0, 532
Remote Config [candidate] (531.006 µs) : 0, 531
Telemetry [baseline] (8.538 ms) : 0, 8538
Telemetry [candidate] (8.589 ms) : 0, 8589
Flare Poller [baseline] (3.422 ms) : 0, 3422
Flare Poller [candidate] (3.421 ms) : 0, 3421
IAST [baseline] (26.89 ms) : 0, 26890
IAST [candidate] (27.163 ms) : 0, 27163
section profiling
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (681.77 ms) : 0, 681770
BytebuddyAgent [candidate] (681.975 ms) : 0, 681975
AgentMeter [baseline] (8.533 ms) : 0, 8533
AgentMeter [candidate] (8.515 ms) : 0, 8515
GlobalTracer [baseline] (216.084 ms) : 0, 216084
GlobalTracer [candidate] (216.012 ms) : 0, 216012
AppSec [baseline] (32.54 ms) : 0, 32540
AppSec [candidate] (32.807 ms) : 0, 32807
Debugger [baseline] (66.956 ms) : 0, 66956
Debugger [candidate] (67.056 ms) : 0, 67056
Remote Config [baseline] (624.608 µs) : 0, 625
Remote Config [candidate] (625.098 µs) : 0, 625
Telemetry [baseline] (8.991 ms) : 0, 8991
Telemetry [candidate] (9.021 ms) : 0, 9021
Flare Poller [baseline] (3.742 ms) : 0, 3742
Flare Poller [candidate] (3.725 ms) : 0, 3725
ProfilingAgent [baseline] (98.492 ms) : 0, 98492
ProfilingAgent [candidate] (99.416 ms) : 0, 99416
Profiling [baseline] (99.072 ms) : 0, 99072
Profiling [candidate] (99.992 ms) : 0, 99992
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 4 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~fde088bb01, baseline=1.60.0-SNAPSHOT~2fa3c0c243
dateFormat X
axisFormat %s
section baseline
no_agent (19.009 ms) : 18813, 19205
. : milestone, 19009,
appsec (18.57 ms) : 18382, 18758
. : milestone, 18570,
code_origins (17.678 ms) : 17504, 17852
. : milestone, 17678,
iast (17.726 ms) : 17548, 17905
. : milestone, 17726,
profiling (20.153 ms) : 19947, 20360
. : milestone, 20153,
tracing (17.812 ms) : 17634, 17990
. : milestone, 17812,
section candidate
no_agent (19.222 ms) : 19024, 19420
. : milestone, 19222,
appsec (18.696 ms) : 18506, 18886
. : milestone, 18696,
code_origins (17.785 ms) : 17608, 17963
. : milestone, 17785,
iast (19.033 ms) : 18838, 19229
. : milestone, 19033,
profiling (18.988 ms) : 18800, 19177
. : milestone, 18988,
tracing (17.649 ms) : 17477, 17821
. : milestone, 17649,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~fde088bb01, baseline=1.60.0-SNAPSHOT~2fa3c0c243
dateFormat X
axisFormat %s
section baseline
no_agent (1.175 ms) : 1163, 1186
. : milestone, 1175,
iast (3.12 ms) : 3079, 3162
. : milestone, 3120,
iast_FULL (5.711 ms) : 5655, 5768
. : milestone, 5711,
iast_GLOBAL (3.486 ms) : 3435, 3536
. : milestone, 3486,
profiling (2.002 ms) : 1983, 2021
. : milestone, 2002,
tracing (1.82 ms) : 1804, 1836
. : milestone, 1820,
section candidate
no_agent (1.178 ms) : 1166, 1189
. : milestone, 1178,
iast (3.54 ms) : 3499, 3580
. : milestone, 3540,
iast_FULL (5.914 ms) : 5854, 5974
. : milestone, 5914,
iast_GLOBAL (3.505 ms) : 3453, 3557
. : milestone, 3505,
profiling (2.07 ms) : 2051, 2088
. : milestone, 2070,
tracing (1.795 ms) : 1778, 1811
. : milestone, 1795,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~fde088bb01, baseline=1.60.0-SNAPSHOT~2fa3c0c243
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (3.7 ms) : 3485, 3916
. : milestone, 3700,
iast (2.251 ms) : 2181, 2320
. : milestone, 2251,
iast_GLOBAL (2.287 ms) : 2218, 2357
. : milestone, 2287,
profiling (2.104 ms) : 2047, 2161
. : milestone, 2104,
tracing (2.054 ms) : 2000, 2107
. : milestone, 2054,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.509 ms) : 2454, 2563
. : milestone, 2509,
iast (2.254 ms) : 2185, 2323
. : milestone, 2254,
iast_GLOBAL (2.293 ms) : 2223, 2362
. : milestone, 2293,
profiling (2.092 ms) : 2036, 2149
. : milestone, 2092,
tracing (2.055 ms) : 2001, 2108
. : milestone, 2055,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~fde088bb01, baseline=1.60.0-SNAPSHOT~2fa3c0c243
dateFormat X
axisFormat %s
section baseline
no_agent (15.39 s) : 15390000, 15390000
. : milestone, 15390000,
appsec (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
iast (18.11 s) : 18110000, 18110000
. : milestone, 18110000,
iast_GLOBAL (17.834 s) : 17834000, 17834000
. : milestone, 17834000,
profiling (15.001 s) : 15001000, 15001000
. : milestone, 15001000,
tracing (14.653 s) : 14653000, 14653000
. : milestone, 14653000,
section candidate
no_agent (15.248 s) : 15248000, 15248000
. : milestone, 15248000,
appsec (14.769 s) : 14769000, 14769000
. : milestone, 14769000,
iast (18.123 s) : 18123000, 18123000
. : milestone, 18123000,
iast_GLOBAL (17.51 s) : 17510000, 17510000
. : milestone, 17510000,
profiling (15.186 s) : 15186000, 15186000
. : milestone, 15186000,
tracing (14.806 s) : 14806000, 14806000
. : milestone, 14806000,
|
nikita-tkachenko-datadog
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
REQUEST_KIND_LEGACY_REQUESTinDDCI_REQUEST_KIND.Motivation
In legacy mode, the
TARGET_SHAenvvar doesn't contain the expected value, causing the computing merge base when running on a PR to either have an unexpected value or fail altogether.Additional Notes
test-environment-trigger: skip
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.